Skip to content

Conversation

@amosie
Copy link

@amosie amosie commented Aug 11, 2015

We don’t currently have a focus style for keyboard/ screenreader users. This PR makes the focus indicator more visible for these users.

Before

screen shot 2015-08-11 at 12 40 08

screen shot 2015-08-11 at 12 42 47
The above screenshot is when the user has scrolled - leaving the point on the page but with focus still on the link.

After

screen shot 2015-08-11 at 12 39 55

screen shot 2015-08-11 at 12 42 01

@mdo
Copy link
Contributor

mdo commented Aug 11, 2015

Why the bright yellow? Doesn't that reduce the contrast? Also, the yellow doesn't really go with the general aesthetics of the site.

@amosie
Copy link
Author

amosie commented Aug 11, 2015

Hey @mdo it does reduce the contrast - but that's OK. Users who need the focus rely on screenreaders - it's about saying "Hey" this is where I am on the page. That's the reason I chose yellow here and why other sites do to.

Any suggestions to make it more GitHubby?

@brianjenkins94
Copy link

Use the same shade of yellow as the emphasis tag perhaps?

http://primercss.io/forms/#checkboxes-and-radios

@amosie
Copy link
Author

amosie commented Aug 11, 2015

@brianjenkins94 that could be a good call - what you think @mdo?

@amosie
Copy link
Author

amosie commented Aug 18, 2015

Gentle bump @mdo

@mdo
Copy link
Contributor

mdo commented Aug 18, 2015

I agree our focus states need improvement, but adding a yellow highlight on focus seems excessive and not all that helpful. Can we start with something simpler?

Also, this is what I see on tab focus to elements in Safari:

screen shot 2015-08-18 at 10 33 15 am

Do we want to move further away from browser defaults on more elements? Currently we override focus styles for textareas, inputs, and buttons only.

@amosie amosie closed this Sep 22, 2015
@amosie
Copy link
Author

amosie commented Sep 22, 2015

Closed out - lets look in to this again when we have more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants